Skip to content

Set new hypnogram format as default #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TomBugnon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set new hypnogram format as default #88

TomBugnon wants to merge 1 commit into from
+5 −3

Conversation

@TomBugnon
Copy link
Collaborator

@TomBugnon TomBugnon commented Feb 17, 2021

There is currently an inconsistency when saving hypnogram data:

the default button of the question box asking whether or not to use the new format is "No [use old format]", while the question text suggests the default should be "Yes":

`Since release 0.4, hypnogram are exported using stage "
"duration rather than point-per-second. This new format "
"avoids potential errors caused by downsampling and "
"confusion in the values assigned to each sleep stage. \n\n"
"Click 'Yes' to use the new format and 'No' to use the old "
"format. For more information, visit the doc at

This PR simply changes the default button to "Yes [use new format]"

@raphaelvallat
Copy link
Collaborator

raphaelvallat commented Feb 17, 2021

All good to me 👍

@raphaelvallat raphaelvallat self-requested a review February 17, 2021 18:47
@raphaelvallat raphaelvallat self-assigned this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raphaelvallat raphaelvallat raphaelvallat approved these changes

Assignees

@raphaelvallat raphaelvallat

Labels

doc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomBugnon @raphaelvallat